Messages in this thread | | | Date | Sun, 21 Sep 2014 09:05:24 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH 2/3] x86, ptdump: Simplify page flag evaluation code |
| |
* Mathias Krause <minipli@googlemail.com> wrote:
> -#define pt_dump_seq_printf(m, to_dmesg, fmt, args...) \ > +#define ptd_print(m, to_dmesg, fmt, args...) \
Please don't abbreviate to non-obvious shortcuts ('ptd'), keep using the pt_dump_ prefix which was just fine.
(If checkpatch complains about lines slightly above 80cols then ignore checkpatch, don't uglify the code.)
Thanks,
Ingo
| |