Messages in this thread | | | From | "Chen, Alvin" <> | Subject | RE: [PATCH 3/3 v2] GPIO: gpio-dwapb: Suspend & Resume PM enabling | Date | Mon, 22 Sep 2014 01:37:05 +0000 |
| |
> > > +/* Store GPIO context across system-wide suspend/resume transitions > > +*/ static struct dwapb_context { > > + u32 data[DWAPB_MAX_PORTS]; > > + u32 dir[DWAPB_MAX_PORTS]; > > + u32 ext[DWAPB_MAX_PORTS]; > > + u32 int_en; > > + u32 int_mask; > > + u32 int_type; > > + u32 int_pol; > > + u32 int_deb; > > +} dwapb_context; > > NAK, this should STILL be part of the device state container. Not a local > variable. > > I've said this before. Please fix this, thanks. > Linus, please review Version 5 that I sent on Sep.17th. I have fixed it in the v5.
| |