lkml.org 
[lkml]   [2014]   [Sep]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 3/3 v2] GPIO: gpio-dwapb: Suspend & Resume PM enabling
Date
> 
> > +/* Store GPIO context across system-wide suspend/resume transitions
> > +*/ static struct dwapb_context {
> > + u32 data[DWAPB_MAX_PORTS];
> > + u32 dir[DWAPB_MAX_PORTS];
> > + u32 ext[DWAPB_MAX_PORTS];
> > + u32 int_en;
> > + u32 int_mask;
> > + u32 int_type;
> > + u32 int_pol;
> > + u32 int_deb;
> > +} dwapb_context;
>
> NAK, this should STILL be part of the device state container. Not a local
> variable.
>
> I've said this before. Please fix this, thanks.
>
Linus, please review Version 5 that I sent on Sep.17th. I have fixed it in the v5.
\
 
 \ /
  Last update: 2014-09-22 04:21    [W:0.068 / U:0.164 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site