lkml.org 
[lkml]   [2014]   [Sep]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCHv2 2/3] x86, ptdump: Simplify page flag evaluation code
On 9/21/2014 8:26 AM, Mathias Krause wrote:
> - if (pr & _PAGE_PCD)
> - pt_dump_cont_printf(m, dmsg, "PCD ");
> - else
> - pt_dump_cont_printf(m, dmsg, " ");
> + pt_dump_cont(m, dmsg, "%-4s", pr & _PAGE_USER ? "USR" : "");

while you have some nice cleanups in your patch, I can't say I consider this an improvement.
Yes the C standard allows ? to be used like this
but no, I don't think it improves readability in general.
(I think for me the main exception is NULL pointer cases, but this is not one of these)




\
 
 \ /
  Last update: 2014-09-21 22:21    [W:0.582 / U:1.856 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site