Messages in this thread | | | Date | Sun, 21 Sep 2014 12:49:33 -0700 | From | Arjan van de Ven <> | Subject | Re: [PATCHv2 2/3] x86, ptdump: Simplify page flag evaluation code |
| |
On 9/21/2014 8:26 AM, Mathias Krause wrote: > - if (pr & _PAGE_PCD) > - pt_dump_cont_printf(m, dmsg, "PCD "); > - else > - pt_dump_cont_printf(m, dmsg, " "); > + pt_dump_cont(m, dmsg, "%-4s", pr & _PAGE_USER ? "USR" : "");
while you have some nice cleanups in your patch, I can't say I consider this an improvement. Yes the C standard allows ? to be used like this but no, I don't think it improves readability in general. (I think for me the main exception is NULL pointer cases, but this is not one of these)
| |