Messages in this thread | | | Date | Sun, 21 Sep 2014 21:43:46 +0200 | From | Helge Deller <> | Subject | Re: linux-next: Tree for Sep 19 |
| |
Hi Günter,
On 09/20/2014 11:01 PM, Guenter Roeck wrote: > On 09/20/2014 12:36 PM, Helge Deller wrote: >> Hi Günter, >> >> On 09/19/2014 09:15 PM, Guenter Roeck wrote: >>> On Fri, Sep 19, 2014 at 04:58:17PM +1000, Stephen Rothwell wrote: >>>> Changes since 20140917: >>>> >>>> The fsl tree still had its build failure so I used the version from >>>> next-20140917. >>>> >>>> The v4l-dvb tree lost its build failure. >>>> >>>> The security tree gained a conflict against the file-locks tree. >>>> >>>> Non-merge commits (relative to Linus' tree): 6014 >>>> 5488 files changed, 217522 insertions(+), 129375 deletions(-) >>>> >>>> ---------------------------------------------------------------------------- >>>> >>> >>> parisc:defconfig, parisc:generic-32bit_defconfig: >>> >>> -------------- >>> Error log: >>> arch/parisc/kernel/ptrace.c: In function 'do_syscall_trace_enter': >>> arch/parisc/kernel/ptrace.c:274:2: error: implicit declaration of function >>> 'secure_computing' [-Werror=implicit-function-declaration] >>> cc1: some warnings being treated as errors >>> make[1]: *** [arch/parisc/kernel/ptrace.o] Error 1 >>> >>> Bisect points to commit 273299fb6380 ('Merge branch 'x86/seccomp') which >>> obviously doesn't help much. Suspected culprit is c90f06943e05 ('parisc: Wire up >>> seccomp, getrandom and memfd_create syscalls') which seems to be missing an >>> include file. > >> I've added this patch to my for-next tree: >> http://git.kernel.org/cgit/linux/kernel/git/deller/parisc-linux.git/commit/?h=for-next&id=0f18557b017b3469e1f8edf5cf34c1cba856fdbe > > That doesn't solve the problem for me, most likely because > HAVE_ARCH_SECCOMP_FILTER is not set for parisc in next-20140919. > This is what seccomp.h does with it: > > #ifdef CONFIG_HAVE_ARCH_SECCOMP_FILTER > static inline int secure_computing(void) { return 0; } > #else > static inline void secure_computing_strict(int this_syscall) { return; } > #endif > > You don't have this flag in your tree. It was introduced in -next with > commit 'seccomp,x86,arm,mips,s390: Remove nr parameter from secure_computing'.
Thanks for the hint! Since parisc currently only supports the strict mode, I've changed the code to call secure_computing_strict() instead of secure_computing() with this commit in my for-next tree: http://git.kernel.org/cgit/linux/kernel/git/deller/parisc-linux.git/commit/?h=for-next&id=fe5c873459a973e59854bd235a7e6b3eaa8e5fe0
It now builds cleanly with the next-20140919 tree.
Thanks! Helge -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |