Messages in this thread | | | Date | Sat, 20 Sep 2014 12:00:27 +0200 | From | Paolo Bonzini <> | Subject | Re: [PATCH RFC 2/2] vhost: support urgent descriptors |
| |
Il 19/09/2014 09:10, Jason Wang ha scritto: >> > >> > - if (!vhost_has_feature(vq, VIRTIO_RING_F_EVENT_IDX)) { >> > + if (vq->urgent || !vhost_has_feature(vq, VIRTIO_RING_F_EVENT_IDX)) { > So the urgent descriptor only work when event index was not enabled? > This seems suboptimal, we may still want to benefit from event index > even if urgent descriptor is used. Looks like we need return true here > when vq->urgent is true?
Its ||, not &&.
Without event index, all descriptors are treated as urgent.
Paolo
| |