lkml.org 
[lkml]   [2014]   [Sep]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH RFC 2/2] vhost: support urgent descriptors
Il 19/09/2014 09:10, Jason Wang ha scritto:
>> >
>> > - if (!vhost_has_feature(vq, VIRTIO_RING_F_EVENT_IDX)) {
>> > + if (vq->urgent || !vhost_has_feature(vq, VIRTIO_RING_F_EVENT_IDX)) {
> So the urgent descriptor only work when event index was not enabled?
> This seems suboptimal, we may still want to benefit from event index
> even if urgent descriptor is used. Looks like we need return true here
> when vq->urgent is true?

Its ||, not &&.

Without event index, all descriptors are treated as urgent.

Paolo



\
 
 \ /
  Last update: 2014-09-20 12:41    [W:1.617 / U:0.916 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site