Messages in this thread | | | Date | Tue, 2 Sep 2014 09:07:23 -0500 (CDT) | From | Christoph Lameter <> | Subject | Re: linux-next: Tree for Sep 1 |
| |
On Tue, 2 Sep 2014, Bartlomiej Zolnierkiewicz wrote:
> Commit 532d0d0690d1 ("irqchips: Replace __this_cpu_ptr uses") > incorrectly converted *__this_cpu_ptr() to raw_cpu_read() instead > of *raw_cpu_ptr(). Fix it.
Oww.. This is double indirection deal there. A percpu offset pointing to a pointer?
Generally the following is true (definition from include/asm-generic/percpu.h that is used for ARM for raw_cpu_read):
#define raw_cpu_read_4(pcp) (*raw_cpu_ptr(&(pcp)))
> Index: b/drivers/irqchip/irq-gic.c > =================================================================== > --- a/drivers/irqchip/irq-gic.c 2014-09-02 14:03:41.026758653 +0200 > +++ b/drivers/irqchip/irq-gic.c 2014-09-02 14:37:04.466811546 +0200 > @@ -102,7 +102,7 @@ static struct gic_chip_data gic_data[MAX > #ifdef CONFIG_GIC_NON_BANKED > static void __iomem *gic_get_percpu_base(union gic_base *base) > { > - return raw_cpu_read(base->percpu_base); > + return *raw_cpu_ptr(base->percpu_base); > } > > static void __iomem *gic_get_common_base(union gic_base *base) > >
| |