Messages in this thread | | | Date | Thu, 18 Sep 2014 10:50:26 -0400 (EDT) | From | Alan Stern <> | Subject | Re: [PATCH v4 1/2] usb: host: ehci-exynos: Remove unnecessary usb-phy support |
| |
On Thu, 18 Sep 2014, Vivek Gautam wrote:
> Now that we have completely moved from older USB-PHY drivers > to newer GENERIC-PHY drivers for PHYs available with USB controllers > on Exynos series of SoCs, we can remove the support for the same > in our host drivers too. > > We also defer the probe for our host in case we end up getting > EPROBE_DEFER error when getting PHYs.
Better now. But I didn't notice this the first time:
> + if (IS_ERR(phy)) { > + ret = PTR_ERR(phy); > + if (ret == -EPROBE_DEFER) { > + return ret; > + } else if (ret != -ENOSYS && ret != -ENODEV) { > + dev_err(dev, > + "Error retrieving usb2 phy: %d\n", ret); > + return PTR_ERR(phy);
It doesn't make any real difference, but wouldn't you prefer to say "return ret" here?
With or without that change, for both these two patches:
Acked-by: Alan Stern <stern@rowland.harvard.edu>
| |