| Date | Thu, 18 Sep 2014 18:00:06 +0800 | From | Jeremy Kerr <> | Subject | Re: [PATCH 01/15] powerpc/cell: Move spu_handle_mm_fault() out of cell platform |
| |
Hi Mikey & Ian,
> Currently spu_handle_mm_fault() is in the cell platform. > > This code is generically useful for other non-cell co-processors on powerpc. > > This patch moves this function out of the cell platform into arch/powerpc/mm so > that others may use it.
Makes sense.
Acked-by: Jeremy Kerr <jk@ozlabs.org>
> @@ -58,12 +56,12 @@ int spu_handle_mm_fault(struct mm_struct *mm, unsigned long ea, > goto out_unlock; > } > > - is_write = dsisr & MFC_DSISR_ACCESS_PUT; > + is_write = dsisr & DSISR_ISSTORE; > if (is_write) { > if (!(vma->vm_flags & VM_WRITE)) > goto out_unlock; > } else { > - if (dsisr & MFC_DSISR_ACCESS_DENIED) > + if (dsisr & DSISR_PROTFAULT) > goto out_unlock; > if (!(vma->vm_flags & (VM_READ | VM_EXEC))) > goto out_unlock;
Consistent DSISR encodings? woot! :)
Cheers,
Jeremy
|