Messages in this thread | | | Date | Wed, 17 Sep 2014 09:17:41 -0700 | Subject | Re: [PATCH v11 net-next 12/12] bpf: mini eBPF library, test stubs and verifier testsuite | From | Alexei Starovoitov <> |
| |
On Wed, Sep 17, 2014 at 12:16 AM, Daniel Borkmann <dborkman@redhat.com> wrote: > > > That actually still doesn't answer my question why the test stub > cannot live in lib/test_bpf where we have our actual testing > framework for eBPF/BPF, also since you exactly only build test_stub.c > when TEST_BPF is enabled which is the Kconfig for lib/test_bpf.
multiple reasons: 1. lib/test_bpf.c is a module, whereas test_stub.c is kernel builtin.
2. I wasn't sure that reusing CONFIG_TEST_BPF for this purpose was a good idea. May be it's better to introduce CONFIG_BPF_VERIFIER_TEST_STUBS or something.
3. kernel/bpf/test_stubs.c can be removed once real tracing or socket use case is in.
| |