Messages in this thread | | | Date | Tue, 16 Sep 2014 15:06:51 -0700 | Subject | Re: [PATCH v12 net-next 03/11] bpf: add lookup/update/delete/iterate methods to BPF maps | From | Alexei Starovoitov <> |
| |
On Tue, Sep 16, 2014 at 2:49 PM, David Miller <davem@davemloft.net> wrote: > From: Alexei Starovoitov <ast@plumgrid.com> > Date: Tue, 16 Sep 2014 14:23:27 -0700 > >> no compat layer and type checking will be done >> by syscall wrappers. Ok? > > Why are you against using strong typing just for everything other > than the user pointer blobs? > > I don't understand the resistence to my suggestion to just use > aligned_u64 instead of "void __user *" in the union members.
All these different variants are ok to me. There are pros and cons to either approach. I'm not against strong typing. I just thought it would be cleaner not to use 'union' and was asking for opinion. That's all. Sure, I will keep 'union' and only change pointers to __aligned_u64.
| |