Messages in this thread | | | From | Jeff Moyer <> | Subject | Re: [PATCH 7/7] check for O_NONBLOCK in all read_iter instances | Date | Tue, 16 Sep 2014 17:24:29 -0400 |
| |
Christoph Hellwig <hch@infradead.org> writes:
>> Again, the right return value for the O_DIRECT case is EINVAL. > > Is it? We define -EAGAIN as it would block, which is defintively true > for O_DIRECT reads.
It will *always* block. So I don't think it's valid to ask for a non-blocking read on a file opened with O_DIRECT. What am I missing?
Cheers, Jeff
| |