lkml.org 
[lkml]   [2014]   [Sep]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 0/7] mtd: denali: A collection of trivial coding style fixes
Hi Masahiro,

On Tue, Sep 16, 2014 at 11:11:58AM +0900, Masahiro Yamada wrote:
> On Mon, 15 Sep 2014 17:36:20 -0700 Brian Norris <computersforpeace@gmail.com> wrote:
> > On Tue, Sep 09, 2014 at 11:01:50AM +0900, Masahiro Yamada wrote:
> > > Changes in v2:
> > > - Join quotes strings into a single line
> > >
> > > Masahiro Yamada (7):
> > > mtd: denali: fix the format of comment blocks
> > > mtd: denali: remove unnecessary variable initializations
> > > mtd: denali: remove unnecessary casts
> > > mtd: denali: change the type of iterators to int
> > > mtd: denali: remove a set-but-unused variable
> > > mtd: denali: remove unnecessary parentheses
> > > mtd: denali: fix indents and other trivial things
> > >
> > > drivers/mtd/nand/denali.c | 562 +++++++++++++++++++++++++---------------------
> > > 1 file changed, 303 insertions(+), 259 deletions(-)
> >
> > Pushed patches 1 to 5 to l2-mtd.git. Thanks!
> >
> > Patch 6 has a conflict with another fix already in l2-mtd.git. Can you
> > rebase and resend?
>
> Sorry for my ignorance, but where can I find l2-mtd.git?

git://git.infradead.org/l2-mtd.git

> In my understanding, the subsystem repositories should be documented
> in MAINTAINERS, so I looked for it but just found
> T: git git://git.infradead.org/linux-mtd.git.
> I do not think it is the one you mentioned.

Sorry, apparently l2-mtd.git is not in MAINTAINERS. It historically has
been a kind of queue for the official repo (linux-mtd.git), especially
when work was split up between two people. I handle most of it now.

I guess it should be in MAINTAINERS, though, since most people will need
to base patches on it. I just sent a patch to add it.

> > BTW, my automatic build tests show that there's at least one other
> > 'unused' warning left, in case you want to tackle it too:
> >
> > drivers/mtd/nand/denali.c: In function ‘denali_read_page_raw’:
> > drivers/mtd/nand/denali.c:1221:11: warning: variable ‘irq_status’ set but not used [-Wunused-but-set-variable]
> > uint32_t irq_status;
> >
>
> You are right.
> (What is odd enough is this warning was not displayed on my build test.
> I do not know why.)

I enabled extra warnings. I think you can get most of those with 'make
W=1'.

> Is there a chance for me to resend 5/7 to include this fix?
> Or is it too late?

Just send a new patch, please.

Thanks,
Brian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2014-09-16 07:41    [W:0.056 / U:0.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site