lkml.org 
[lkml]   [2014]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] net: can: usb: peak_usb: pcan_usb_core.c: Cleaning up missing null-terminate in conjunction with strncpy
    Acked-by: Stephane Grosjean <s.grosjean@peak-system.com>

    Le 14/09/2014 19:31, Rickard Strandqvist a écrit :
    > Replacing strncpy with strlcpy to avoid strings that lacks null terminate.
    >
    > Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
    > ---
    > drivers/net/can/usb/peak_usb/pcan_usb_core.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/drivers/net/can/usb/peak_usb/pcan_usb_core.c b/drivers/net/can/usb/peak_usb/pcan_usb_core.c
    > index 644e6ab..d4fe8ac 100644
    > --- a/drivers/net/can/usb/peak_usb/pcan_usb_core.c
    > +++ b/drivers/net/can/usb/peak_usb/pcan_usb_core.c
    > @@ -830,7 +830,7 @@ static void peak_usb_disconnect(struct usb_interface *intf)
    > char name[IFNAMSIZ];
    >
    > dev->state &= ~PCAN_USB_STATE_CONNECTED;
    > - strncpy(name, netdev->name, IFNAMSIZ);
    > + strlcpy(name, netdev->name, IFNAMSIZ);
    >
    > unregister_netdev(netdev);
    > free_candev(netdev);

    --
    PEAK-System Technik GmbH, Otto-Roehm-Strasse 69, D-64293 Darmstadt
    Geschaeftsleitung: A.Gach/U.Wilhelm,St.Nr.:007/241/13586 FA Darmstadt
    HRB-9183 Darmstadt, Ust.IdNr.:DE 202220078, WEE-Reg.-Nr.: DE39305391
    Tel.+49 (0)6151-817320 / Fax:+49 (0)6151-817329, info@peak-system.com
    --
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2014-09-15 10:41    [W:4.642 / U:4.804 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site