lkml.org 
[lkml]   [2014]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] perf symbols: Add path to Ubuntu kernel debuginfo file
Em Fri, Sep 12, 2014 at 03:43:28PM +0900, Namhyung Kim escreveu:
> On Tue, 9 Sep 2014 09:11:52 +1000, Anton Blanchard wrote:
> > Ubuntu places the kernel debuginfo in /usr/lib/debug/boot/vmlinux-*
> >
> > Signed-off-by: Anton Blanchard <anton@samba.org>
>
> It seems that you need to rebase it onto current acme/perf/core as
> there're little change in this area. The patch itself looks good to me.

I updated the patch, to make it use the kernel_version from the
perf.data file if present, else it uses uts.release as in Anton's patch,
ok?

- Arnaldo

> Thanks,
> Namhyung
>
>
> > ---
> >
> > Index: b/tools/perf/util/symbol.c
> > ===================================================================
> > --- a/tools/perf/util/symbol.c
> > +++ b/tools/perf/util/symbol.c
> > @@ -1750,7 +1750,7 @@ static int vmlinux_path__init(void)
> > struct utsname uts;
> > char bf[PATH_MAX];
> >
> > - vmlinux_path = malloc(sizeof(char *) * 5);
> > + vmlinux_path = malloc(sizeof(char *) * 6);
> > if (vmlinux_path == NULL)
> > return -1;
> >
> > @@ -1784,6 +1784,12 @@ static int vmlinux_path__init(void)
> > uts.release);
> > vmlinux_path[vmlinux_path__nr_entries] = strdup(bf);
> > if (vmlinux_path[vmlinux_path__nr_entries] == NULL)
> > + goto out_fail;
> > + ++vmlinux_path__nr_entries;
> > + snprintf(bf, sizeof(bf), "/usr/lib/debug/boot/vmlinux-%s",
> > + uts.release);
> > + vmlinux_path[vmlinux_path__nr_entries] = strdup(bf);
> > + if (vmlinux_path[vmlinux_path__nr_entries] == NULL)
> > goto out_fail;
> > ++vmlinux_path__nr_entries;
> >


\
 
 \ /
  Last update: 2014-09-15 22:21    [W:0.079 / U:0.472 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site