lkml.org 
[lkml]   [2014]   [Sep]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] arch/microblaze/kernel/setup.c: Add default 'screen_info" for fixing compiling break
From
Hi Chen,

On Sun, Sep 14, 2014 at 10:32 AM, Chen Gang <gang.chen.5i5j@gmail.com> wrote:
> Add default one just like other architectures have done (e.g. cris,
> score, sh ...), the related error with allmodconfig:
>
> LD init/built-in.o
> drivers/built-in.o: In function `vgacon_save_screen':
> drivers/video/console/.tmp_vgacon.o:(.text+0x834d0): undefined reference to `screen_info'
> drivers/video/console/.tmp_vgacon.o:(.text+0x834ec): undefined reference to `screen_info'
> drivers/built-in.o: In function `vgacon_resize':
> drivers/video/console/.tmp_vgacon.o:(.text+0x83cdc): undefined reference to `screen_info'
> drivers/video/console/.tmp_vgacon.o:(.text+0x83d38): undefined reference to `screen_info'
> drivers/built-in.o: In function `vgacon_switch':
> drivers/video/console/.tmp_vgacon.o:(.text+0x83f50): undefined reference to `screen_info'
> drivers/built-in.o:drivers/video/console/.tmp_vgacon.o:(.text+0x8407c): more undefined references to `screen_info' follow
> make: *** [vmlinux] Error 1

Can microblaze actually have VGA?

If not, it's better to disable it.

BTW, it's interesting you mention cris, as VGA_CONSOLE depends on !CRIS
in drivers/video/console/Kconfig...

I (still) think it's time to introduce ARCH_MIGHT_HAVE_VGA, and make
VGA_CONSOLE depend on that, cfr.

commit f13399f033ae3d49e1808bacabd83d116844c94e
Merge: 049ffa8ab33a b2c32b32a212
Author: Linus Torvalds <torvalds@linux-foundation.org>
Date: Fri Nov 15 14:05:15 2013 -0800

Merge tag 'for-linus' of
git://linux-c6x.org/git/projects/linux-c6x-upstreaming

Pull Kconfig cleanups from Mark Salter:
"Remove some unused config options from C6X and clean up PC_PARPORT
dependencies. The latter was discussed here:

https://lkml.org/lkml/2013/10/8/12"

* tag 'for-linus' of git://linux-c6x.org/git/projects/linux-c6x-upstreaming:
c6x: remove unused COMMON_CLKDEV Kconfig parameter
Kconfig cleanup (PARPORT_PC dependencies)
x86: select ARCH_MIGHT_HAVE_PC_PARPORT
unicore32: select ARCH_MIGHT_HAVE_PC_PARPORT
sparc: select ARCH_MIGHT_HAVE_PC_PARPORT
sh: select ARCH_MIGHT_HAVE_PC_PARPORT
powerpc: select ARCH_MIGHT_HAVE_PC_PARPORT
parisc: select ARCH_MIGHT_HAVE_PC_PARPORT
mips: select ARCH_MIGHT_HAVE_PC_PARPORT
microblaze: select ARCH_MIGHT_HAVE_PC_PARPORT
m68k: select ARCH_MIGHT_HAVE_PC_PARPORT
ia64: select ARCH_MIGHT_HAVE_PC_PARPORT
arm: select ARCH_MIGHT_HAVE_PC_PARPORT
alpha: select ARCH_MIGHT_HAVE_PC_PARPORT
c6x: remove unused parameter in Kconfig

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds


\
 
 \ /
  Last update: 2014-09-14 11:21    [W:0.161 / U:0.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site