Messages in this thread | | | Date | Mon, 1 Sep 2014 18:51:19 +0200 | Subject | Re: [PATCH] brcmfmac: BRCMFMAC should depend on HAS_DMA | From | Geert Uytterhoeven <> |
| |
Hi Arend,
On Mon, Sep 1, 2014 at 2:54 PM, Arend van Spriel <arend@broadcom.com> wrote: > On 09/01/14 10:44, Geert Uytterhoeven wrote: >> On Mon, Sep 1, 2014 at 10:21 AM, Arend van Spriel<arend@broadcom.com> >> wrote: >>>> >>>> config BRCMFMAC >>>> tristate "Broadcom IEEE802.11n embedded FullMAC WLAN driver" >>>> - depends on CFG80211 >>>> + depends on CFG80211A&& HAS_DMA >>> >>> Not sure what happened here, but CFG80211 kconfig option did was not >>> renamed >>> as far as I know. Anyway, I would like to propose a different solution. >>> Will get back to you when I have it ready.
> I added Kconfig options for the proto layer which are selected by the host > interface selection. So the HAS_DMA dependency is checked for BRCMFMAC_PCIE.
Thanks!
> I am wondering whether GENERIC_IO should also be checked.
Probably not. Let's see if anyone complains ;-)
> Can you verify the patch below works with your configuration?
Yes, it compiles and links fine now (after applying it manually due to whitespace mess-up).
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |