Messages in this thread | | | From | Jeff Moyer <> | Subject | Re: [PATCH 4/4] usb: gadget: fix error return code | Date | Thu, 07 Aug 2014 17:50:08 -0400 |
| |
Julia Lawall <Julia.Lawall@lip6.fr> writes:
> diff --git a/drivers/usb/gadget/udc/fusb300_udc.c b/drivers/usb/gadget/udc/fusb300_udc.c > index d40255f..5c5d1ad 100644 > --- a/drivers/usb/gadget/udc/fusb300_udc.c > +++ b/drivers/usb/gadget/udc/fusb300_udc.c > @@ -1398,13 +1398,17 @@ static int fusb300_probe(struct platform_device *pdev) > > /* initialize udc */ > fusb300 = kzalloc(sizeof(struct fusb300), GFP_KERNEL); > - if (fusb300 == NULL) > + if (fusb300 == NULL) { > + ret = -ENOMEM; > goto clean_up; > + } > > for (i = 0; i < FUSB300_MAX_NUM_EP; i++) { > _ep[i] = kzalloc(sizeof(struct fusb300_ep), GFP_KERNEL); > - if (_ep[i] == NULL) > + if (_ep[i] == NULL) { > + ret = -ENOMEM; > goto clean_up; > + } > fusb300->ep[i] = _ep[i]; > }
Reviewed-by: Jeff Moyer <jmoyer@redhat.com>
| |