Messages in this thread | | | From | Alex Bennée <> | Subject | Re: [PATCH] arm64: KVM: export current vcpu->pause state via pseudo regs | Date | Mon, 04 Aug 2014 13:35:15 +0100 |
| |
Christoffer Dall writes:
> On Thu, Jul 31, 2014 at 07:21:44PM +0200, Paolo Bonzini wrote: >> Il 31/07/2014 19:04, Peter Maydell ha scritto: >> > On 31 July 2014 17:57, Paolo Bonzini <pbonzini@redhat.com> wrote: >> >> Il 09/07/2014 15:55, Alex Bennée ha scritto: <snip> >> >> No, it's not. It's just the state of the CPU, s390 will be using it too. >> >> On x86 the states are uninitialized (UNINITIALIZED), stopped >> (INIT_RECEIVED), running (RUNNABLE), halted (HALTED). CPU 0 starts in >> RUNNABLE state, other CPUs start in UNINITIALIZED state. There are >> x86-specific cases (uninitialized) and x86-isms (the INIT_RECEIVED >> name), but the idea is widely applicable. >> > Alex, I think it makes perfect sense to use GET/SET_MP_STATE, will you > revise the patch?
I agree we should use the API that is explicitly for this so I'm looking at re-doing the patch now.
> > (Don't forget to update the documentation to reflect it is now supported > on ARM, and which states are used to represent what there.) > > Thanks, > -Christoffer
-- Alex Bennée -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |