lkml.org 
[lkml]   [2014]   [Aug]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/4] Add the "verbose" module option.
On Sun, 03 Aug 2014 17:12:57 +0200, Goffredo Baroncelli wrote:
> On 08/03/2014 04:12 PM, Jean Delvare wrote:
> >> + (verbose > 0 && level >= 0)) {
> >> + print_temp("CPU-temp: ", temp );
> >> + if (casetemp)
> >> + print_temp(", Case: ", casetemp );
> >> + if (level >= 0)
> >> + printk(", Fan: %d (tuned %+d)\n", 11-level,
> >> + x.fan_level-level );
> >> + else
> >> + printk(", Fan: %d (tuned +0)\n",x.fan_level);
> >
> > I think you can do without the "tuned +0" which doesn't add much value.
>
> Me too. But the old driver does the same, so I preferred to
> leave it as is.

I looked at the code again and no, I can't see the old code doing that.
It has "tuned %+d" only in tune_fan() which is only called if
level >= 0. The other printk (when tune_fan isn't called) doesn't have
a "tuned" part.

--
Jean Delvare
SUSE L3 Support


\
 
 \ /
  Last update: 2014-08-03 18:21    [W:0.035 / U:0.488 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site