Messages in this thread | | | Date | Fri, 29 Aug 2014 17:14:07 -0700 | From | Stephen Boyd <> | Subject | Re: [PATCH v2] hwspinlock/msm: Add support for Qualcomm MSM HW Mutex block |
| |
On 08/29/14 16:41, Courtney Cavin wrote: > On Sat, Aug 30, 2014 at 01:14:23AM +0200, Bjorn Andersson wrote: >> From: Kumar Gala <galak@codeaurora.org> >> >> Add driver for Qualcomm MSM Hardware Mutex block that exists on >> newer Qualcomm SoCs. >> >> Cc: Jeffrey Hugo <jhugo@codeaurora.org> >> Cc: Eric Holmberg <eholmber@codeaurora.org> >> Cc: Courtney Cavin <courtney.cavin@sonymobile.com> >> Signed-off-by: Kumar Gala <galak@codeaurora.org> >> [bjorn: added pm_runtime calls, from Courtney, >> added sfpb-mutex compatible, >> updated DT binding documentation formatting] >> Signed-off-by: Bjorn Andersson <bjorn.andersson@sonymobile.com> >> --- > [...] >> diff --git a/drivers/hwspinlock/Kconfig b/drivers/hwspinlock/Kconfig >> index 3612cb5..2cd39e2 100644 >> --- a/drivers/hwspinlock/Kconfig >> +++ b/drivers/hwspinlock/Kconfig >> @@ -8,6 +8,17 @@ config HWSPINLOCK >> >> menu "Hardware Spinlock drivers" >> >> +config HWSPINLOCK_MSM >> + tristate "MSM Hardware Spinlock device" >> + depends on ARCH_QCOM > This should also depend on OF, as it won't compile or work without it.
Doesn't ARCH_QCOM imply OF? ARCH_MULTIPLATFORM has a select USE_OF.
> >> + select HWSPINLOCK >> + help >> + Say y here to support the MSM Hardware Mutex functionality, which >> + provides a synchronisation mechanism for the various processors on >> + the SoC. >> + >> + If unsure, say N. >> + >>
Maybe MSM should be changed to qcom? Just a thought.
-- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
| |