lkml.org 
[lkml]   [2014]   [Aug]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] mm: page_alloc: avoid wakeup kswapd on the unintended node
From
On Fri, Aug 29, 2014 at 4:12 PM, Mel Gorman <mgorman@suse.de> wrote:
> On Fri, Aug 29, 2014 at 03:03:19PM +0800, Weijie Yang wrote:
>> When enter page_alloc slowpath, we wakeup kswapd on every pgdat
>> according to the zonelist and high_zoneidx. However, this doesn't
>> take nodemask into account, and could prematurely wakeup kswapd on
>> some unintended nodes.
>>
>> This patch uses for_each_zone_zonelist_nodemask() instead of
>> for_each_zone_zonelist() in wake_all_kswapds() to avoid the above situation.
>>
>> Signed-off-by: Weijie Yang <weijie.yang@samsung.com>
>
> Just out of curiousity, did you measure a problem due to this or is
> the patch due to code inspection? It was known that we examined useless
> nodes but assumed to not be a problem because the watermark check should
> prevent spurious wakeups. However, we do a cpuset check and this patch
> is consistent with that so regardless of why you wrote the patch

It is a patch due to code review :-)

> Acked-by: Mel Gorman <mgorman@suse.de>
>
> --
> Mel Gorman
> SUSE Labs


\
 
 \ /
  Last update: 2014-08-29 11:21    [W:0.069 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site