Messages in this thread | | | Date | Thu, 28 Aug 2014 16:49:57 +0100 | From | David Vrabel <> | Subject | Re: [PATCH] drivers/xen/evtchn.c: Check failure for evtchn_make_refcounted() |
| |
On 28/08/14 16:13, Chen Gang wrote: > evtchn_make_refcounted() may return failure, so need process the failure > case. In failure case, it need call unbind_from_irqhandler() just like > evtchn_unbind_from_user() has done. > > irq_from_evtchn() must be OK when bind_evtchn_to_irqhandler() succeed, > so need not check it again. > > Also still need remain the closing port code, because when the failure > occurs, unbind_from_irqhandler() will not close port internally.
None of the evtchn_make_refcounted() failures can occur since we know we have a valid irq and info at the single call site.
I would like to see this fixed by refactoring the code to remove evtchn_make_refcounted() by making all irqs for event channels reference counted. These no need for this refcounting to be optional.
David
| |