Messages in this thread | | | Date | Wed, 27 Aug 2014 17:03:41 -0400 (EDT) | From | Alan Stern <> | Subject | Re: [PATCH v4 1/3] usb: gadget: Refactor request completion |
| |
On Wed, 27 Aug 2014, Michal Sojka wrote:
> +/** > + * usb_gadget_giveback_request - give the request back to the gadget layer > + * Context: in_interrupt() > + * > + * This is called by device controller drivers in order to return the > + * completed request back to the gadget layer. > + */ > +void usb_gadget_giveback_request(struct usb_ep *ep, > + struct usb_request *req) > +{ > + BUG_ON(req->complete == NULL); > + req->complete(ep, req); > +}
I guess it doesn't hurt to have the BUG_ON, but it doesn't help either. Think about what would happen if req->complete was NULL and the BUG_ON wasn't present.
Alan Stern
| |