Messages in this thread | | | Date | Mon, 25 Aug 2014 00:00:24 -0700 (PDT) | Subject | Re: [PATCH net-next 0/4] r8152: firmware support | From | David Miller <> |
| |
From: Hayes Wang <hayeswang@realtek.com> Date: Mon, 25 Aug 2014 06:43:02 +0000
> Except the step 3, 4, 6 and 7, the other steps depend on the > context of the firmware. That is, for different firmware, some > actions would be removed or added, and some settings would be > different. Especially the step 8, it often different for > different firmwares. Should I add some firmware version check > in the source code?
This is extremely poor design of the firmware, adding such constantly changing dependencies and constantly changing programming sequences just to get the firmare executing is a terrible idea.
You really need to sanitize this in some way, because what you have posted is totally unacceptable to me.
| |