Messages in this thread | | | Date | Fri, 22 Aug 2014 09:31:20 -0700 | From | Sören Brinkmann <> | Subject | Re: [PATCH 3/3] ARM: zynq: DT: Add Ethernet phys |
| |
On Fri, 2014-08-22 at 10:20AM -0600, Jason Gunthorpe wrote: > On Thu, Aug 21, 2014 at 08:49:19AM -0700, Sören Brinkmann wrote: > > > So my thinkings: > > - the compatible string with the -c22 is used and documented in the phy > > bindings, it should be there. > > Yes > > > - the ID based strings seem to be not needed since, IIUC, the core > > reads the ID from the PHY and uses it, so I just left it out not > > trying to figure out how to obtain the correct ID > > It is certainly optional, I added the property to solve some obscure > problems with probing, but I've noticed people using it more broadly. > I suspect it also speeds up booting a tiny bit. > > > - the marvell compatible strings are used in our vendor tree. They > > aren't used anywhere but in our vendor tree. I though keeping them is > > nice since it identifies the PHY fully. And in case that level of > > detail is needed at some point it is already there. > > DT is complex enough already, don't include useless compatible strings > in mainline - people will see and tend to blindly copy. Ideally your > vendor tree would use the standard property :|
There are different opinions on this. I also heard to just add such strings, so in case this level of differentiation becomes necessary at some later point, it is already existing.
Sören
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |