Messages in this thread | | | Date | Wed, 20 Aug 2014 20:35:06 -0300 | From | Rafael Aquini <> | Subject | Re: [PATCH 3/7] mm/balloon_compaction: isolate balloon pages without lru_lock |
| |
On Wed, Aug 20, 2014 at 07:04:46PM +0400, Konstantin Khlebnikov wrote: > LRU-lock isn't required for balloon page isolation. This check makes migration > of some ballooned pages mostly impossible because isolate_migratepages_range() > drops LRU lock periodically. > just for historical/explanatory purposes: https://lkml.org/lkml/2013/12/6/183
> Signed-off-by: Konstantin Khlebnikov <k.khlebnikov@samsung.com> > Cc: stable <stable@vger.kernel.org> # v3.8 > --- > mm/compaction.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index 21bf292..0653f5f 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -597,7 +597,7 @@ isolate_migratepages_range(struct zone *zone, struct compact_control *cc, > */ > if (!PageLRU(page)) { > if (unlikely(balloon_page_movable(page))) { > - if (locked && balloon_page_isolate(page)) { > + if (balloon_page_isolate(page)) { > /* Successfully isolated */ > goto isolate_success; > } > Acked-by: Rafael Aquini <aquini@redhat.com>
| |