lkml.org 
[lkml]   [2014]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 1/2] params: Add a per cpu module param type
Date
Andi Kleen <andi@firstfloor.org> writes:
> From: Andi Kleen <ak@linux.intel.com>
>
> This is mainly useful for simple statistic counters.
> Essentially read-only, writing only clears.

Nice...

> +#define param_check_percpu_uint(name, p) param_check_uint

This is wrong; will it even compile? It should also do the __percpu
annotation so hopefully sparse will catch any misuses, eg:

#define param_check_percpu_uint(name, p) \
__param_check(name, p, __percpu unsigned int)

The rest looks good, but I'll need a user :)

Cheers,
Rusty.


\
 
 \ /
  Last update: 2014-08-19 20:21    [W:0.037 / U:0.480 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site