Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [PATCH 1/2] params: Add a per cpu module param type | Date | Wed, 20 Aug 2014 03:37:48 +0930 |
| |
Andi Kleen <andi@firstfloor.org> writes: > From: Andi Kleen <ak@linux.intel.com> > > This is mainly useful for simple statistic counters. > Essentially read-only, writing only clears.
Nice...
> +#define param_check_percpu_uint(name, p) param_check_uint
This is wrong; will it even compile? It should also do the __percpu annotation so hopefully sparse will catch any misuses, eg:
#define param_check_percpu_uint(name, p) \ __param_check(name, p, __percpu unsigned int)
The rest looks good, but I'll need a user :)
Cheers, Rusty.
| |