Messages in this thread Patch in this message | | | From | "Sharma, Sanjeev" <> | Subject | RE: [PATCH] zd1211rw: replace ZD_ASSERT with lockdep_assert_held() | Date | Tue, 19 Aug 2014 06:39:29 +0000 |
| |
Ping for review the patch.
thanks,
Sanjeev Sharma -----Original Message----- From: Sanjeev Sharma [mailto:sanjeev_sharma@mentor.com] Sent: Tuesday, August 12, 2014 12:36 PM To: dsd@gentoo.org; kune@deine-taler.de Cc: linville@tuxdriver.com; linux-wireless@vger.kernel.org; netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Sharma, Sanjeev; Sharma, Sanjeev Subject: [PATCH] zd1211rw: replace ZD_ASSERT with lockdep_assert_held()
on some architecture spin_is_locked() always return false in uniprocessor configuration and therefore it would be advise to replace with lockdep_assert_held().
Signed-off-by: Sanjeev Sharma <Sanjeev_Sharma@mentor.com> --- drivers/net/wireless/zd1211rw/zd_mac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/zd1211rw/zd_mac.c b/drivers/net/wireless/zd1211rw/zd_mac.c index e7af261..72c0bc2 100644 --- a/drivers/net/wireless/zd1211rw/zd_mac.c +++ b/drivers/net/wireless/zd1211rw/zd_mac.c @@ -235,7 +235,7 @@ void zd_mac_clear(struct zd_mac *mac) { flush_workqueue(zd_workqueue); zd_chip_clear(&mac->chip); - ZD_ASSERT(!spin_is_locked(&mac->lock)); + lockdep_assert_held(!spin_is_locked(&mac->lock)); ZD_MEMCLEAR(mac, sizeof(struct zd_mac)); } -- 1.7.11.7
| |