Messages in this thread | | | From | Namhyung Kim <> | Subject | Re: [PATCH 03/13] perf annotate: Move session handling out of __cmd_annotate() | Date | Tue, 19 Aug 2014 15:03:54 +0900 |
| |
On Wed, 13 Aug 2014 13:48:22 +0200, Jiri Olsa wrote: > On Tue, Aug 12, 2014 at 03:40:35PM +0900, Namhyung Kim wrote: >> + annotate.session = perf_session__new(&file, false, &annotate.tool); >> + if (annotate.session == NULL) >> + return -ENOMEM; > > I know you're just moving code, but perf_session__new could > fail for more reasons than just ENOMEM, which is the most > unlikely case ;-) -1 is probably better option here
Okay, will change as a separate fix later.
Thanks, Namhyung
| |