lkml.org 
[lkml]   [2014]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/1] staging: imx-drm: Lines over 80 characters fixed.
From
Date
Am Dienstag, den 19.08.2014, 16:59 +0300 schrieb Yannis Damigos:
> This is a patch to the ipuv3-crtc.c file that fixes up two "lines
> over 80 characters" warnings found by the checkpatch.pl tool.
>
> Signed-off-by: Yannis Damigos <giannis.damigos@gmail.com>
> ---
> drivers/staging/imx-drm/ipuv3-crtc.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/imx-drm/ipuv3-crtc.c b/drivers/staging/imx-drm/ipuv3-crtc.c
> index 720868b..c4c6455 100644
> --- a/drivers/staging/imx-drm/ipuv3-crtc.c
> +++ b/drivers/staging/imx-drm/ipuv3-crtc.c
> @@ -201,9 +201,9 @@ static int ipu_crtc_mode_set(struct drm_crtc *crtc,
> return ret;
> }
>
> - return ipu_plane_mode_set(ipu_crtc->plane[0], crtc, mode, crtc->primary->fb,
> - 0, 0, mode->hdisplay, mode->vdisplay,
> - x, y, mode->hdisplay, mode->vdisplay);
> + return ipu_plane_mode_set(ipu_crtc->plane[0], crtc, mode,
> + crtc->primary->fb, 0, 0, mode->hdisplay, mode->vdisplay,
> + x, y, mode->hdisplay, mode->vdisplay);
> }
>
> static void ipu_crtc_handle_pageflip(struct ipu_crtc *ipu_crtc)

This doesn't improve readability, though. Can we keep the alignment of
the x/y/width/height parameters?

> @@ -227,7 +227,8 @@ static irqreturn_t ipu_irq_handler(int irq, void *dev_id)
>
> if (ipu_crtc->newfb) {
> ipu_crtc->newfb = NULL;
> - ipu_plane_set_base(ipu_crtc->plane[0], ipu_crtc->base.primary->fb,
> + ipu_plane_set_base(ipu_crtc->plane[0],
> + ipu_crtc->base.primary->fb,
> ipu_crtc->plane[0]->x, ipu_crtc->plane[0]->y);
> ipu_crtc_handle_pageflip(ipu_crtc);
> }

regards
Philipp



\
 
 \ /
  Last update: 2014-08-19 16:21    [W:1.000 / U:0.220 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site