Messages in this thread | | | Date | Tue, 19 Aug 2014 19:29:05 +0800 | From | Hanjun Guo <> | Subject | Re: [PATCH v2 09/18] ACPI / processor: Make it possible to get CPU hardware ID via GICC |
| |
On 2014-8-19 2:34, Sudeep Holla wrote: [...] >> >> +#include <asm/smp_plat.h> >> + >> /* Basic configuration for ACPI */ >> #ifdef CONFIG_ACPI >> /* >> @@ -59,6 +61,18 @@ static inline void disable_acpi(void) >> acpi_noirq = 1; >> } >> >> +u32 pack_mpidr_into_32_bits(u64 mpidr); >> + >> +/* >> + * The ACPI processor driver for ACPI core code needs this macro >> + * to find out this cpu was already mapped (mapping from CPU hardware >> + * ID to CPU logical ID) or not. >> + * >> + * cpu_logical_map(cpu) is the mapping of MPIDR and the logical cpu, >> + * and MPIDR is the cpu hardware ID we needed. > > You need to specify this is packed version of cpu_logical_map or > better is to move pack_mpidr_into_32_bits here along with the > description you have so that it's easy to understand.
Agreed, I will make pack_mpidr_into_32_bits() as inline function here and specify that it is the packed version we needed.
Thanks Hanjun
| |