Messages in this thread | | | Date | Tue, 19 Aug 2014 13:44:27 +0300 | From | Mathias Nyman <> | Subject | Re: [PATCH] gpio-lynxpoint: enable input sensing in resume |
| |
On 08/19/2014 01:22 PM, Mika Westerberg wrote: > On Tue, Aug 19, 2014 at 01:30:28PM +0300, Mathias Nyman wrote: >> It appears that input sensing bit might be reset during >> suspend/resume. Set input sensing again for all requested gpios >> in resume >> >> Tested-by: Jerome Blin <jerome.blin@intel.com> >> Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com> >> --- >> drivers/gpio/gpio-lynxpoint.c | 24 ++++++++++++++++++++++++ >> 1 file changed, 24 insertions(+) >> >> diff --git a/drivers/gpio/gpio-lynxpoint.c b/drivers/gpio/gpio-lynxpoint.c >> index ff9eb91..4165672 100644 >> --- a/drivers/gpio/gpio-lynxpoint.c >> +++ b/drivers/gpio/gpio-lynxpoint.c >> @@ -407,9 +407,33 @@ static int lp_gpio_runtime_resume(struct device *dev) >> return 0; >> } >> >> +static int lp_gpio_suspend(struct device *dev) >> +{ >> + return 0; >> +} > > If this function doesn't do anything why it needs to be defined here? >
I guess it doesn't, Added the suspend and resume functions as a pair, but only resume turned out to do something,
I'll remove it.
-Mathias
| |