Messages in this thread | | | Date | Mon, 18 Aug 2014 18:52:46 +0200 | From | Lars-Peter Clausen <> | Subject | Re: [alsa-devel] [PATCH V1 1/3] ASoC: fsl: Kconfig: remove dependence of SND_IMX_SOC for SND_SOC_IMX_PCM_DMA |
| |
On 08/18/2014 10:38 AM, Shengjiu Wang wrote: > Build kernel with SND_SOC_IMC_PCM_DMA=m && SND_IMX_SOC=n leads the following > error: > > sound/built-in.o: In function `fsl_sai_probe': >>> fsl_sai.c:(.text+0x5f662): undefined reference to `imx_pcm_dma_init' > sound/built-in.o: In function `fsl_esai_probe': >>> fsl_esai.c:(.text+0x6044b): undefined reference to `imx_pcm_dma_init' > > Most cpu driver in soc/fsl has use the function 'imx_pcm_dma_init' which is > defined in imx-pcm-dma.c, so need to select SND_SOC_IMX_PCM_DMA, but it depends > on SND_IMX_SOC, if SND_IMX_SOC=n, then SND_SOC_IMX_PCM_DMA will not be > selected. > So remove the dependence of SND_IMX_SOC for SND_SOC_IMX_PCM_DMA. > > Reported-by: kbuild test robot <fengguang.wu@intel.com> > Signed-off-by: Shengjiu Wang <shengjiu.wang@freescale.com>
Those if conditions where just added[1] by Arnd to avoid other build failures. So just removing them again makes little sense.
As far as I can see imx_pcm_dma_init() should be stubbed out when SND_SOC_IMX_PCM_DMA is not selected. So what's going on here?
[1] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=ff40260f79dc0436604452bccd449bffd25ebafb
| |