Messages in this thread | | | Date | Wed, 13 Aug 2014 16:27:54 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH 01/13] perf script: Fix possible memory leaks |
| |
Em Wed, Aug 13, 2014 at 04:05:24PM +0900, Namhyung Kim escreveu: > On Wed, 13 Aug 2014 09:21:31 +0300, Adrian Hunter wrote: > > On 08/12/2014 09:40 AM, Namhyung Kim wrote: > >> input = open(file.path, O_RDONLY); /* input_name */ > >> if (input < 0) { > >> perror("failed to open file"); > >> - return -1; > >> + err = -errno; > > > > Need to get errno before calling perror(). > > Argh, right.
I'll fix this up, no need to resubmit.
- Arnaldo
| |