lkml.org 
[lkml]   [2014]   [Aug]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [Patch] freezer: check OOM kill signal while being frozen
    From
    On Mon, Aug 11, 2014 at 6:18 AM, Michal Hocko <mhocko@suse.cz> wrote:
    >
    > OK, so the system/memcg is still OOM and a new allocation/charge
    > would trigger killer again, right? Then oom_scan_process_thread sees
    > TIF_MEMDIE frozen task and thaw it so it can go away and die. So this
    > shouldn't be a permanent state. Or am I missing something?
    >

    Good point!

    Reading the code again, I think David's commit (f660daac) doesn't
    work any more, __thaw_task() just checks if it's frozen and then wakes
    it up, but the frozen task, after waking up, will check if it's freezing() and
    continue to freeze itself if so. __thaw_task() can't make freezing() return
    false since it doesn't change any of these conditions, especially
    cgroup_freezing().

    This reminds me I should revert that code in oom_killer, checking
    TIF_MEMDIE in __refrigerator() is more correct and clear.

    I will update my patch.

    Thanks!


    \
     
     \ /
      Last update: 2014-08-12 02:41    [W:2.864 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site