Messages in this thread | | | Date | Fri, 1 Aug 2014 19:37:48 +0100 | From | Mark Brown <> | Subject | Re: [PATCHv10 2/4] mailbox: Introduce framework for mailbox |
| |
On Fri, Aug 01, 2014 at 06:01:36PM +0530, Jassi Brar wrote: > Introduce common framework for client/protocol drivers and > controller drivers of Inter-Processor-Communication (IPC). > > Client driver developers should have a look at > include/linux/mailbox_client.h to understand the part of > the API exposed to client drivers. > Similarly controller driver developers should have a look > at include/linux/mailbox_controller.h
Reviewed-by: Mark Brown <broonie@linaro.org>
One very minor thing:
> + t = add_to_rbuf(chan, mssg); > + if (t < 0) { > + pr_err("Try increasing MBOX_TX_QUEUE_LEN\n"); > + return t; > + }
In this and the other error messages it's probably worth doing something like a dev_ print with the device in the mbox_controller - if there's more than one mailbox controller in the system it may well make someone's life easier to get a hint about which one is running into trouble. Similarly if there were some identification for the channels that might be useful to display that (perhaps add a name field people can initialize if they like in the struct?).
This is clearly not a blocker for merge though. [unhandled content-type:application/pgp-signature] | |