lkml.org 
[lkml]   [2014]   [Aug]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [scheduler] BUG: unable to handle kernel paging request at 000000000000ce50
On Thu, 31 Jul 2014, Lai Jiangshan wrote:

> > this_cpu_ptr instead.
>
>
> - struct cpumask *cpus = __get_cpu_var(load_balance_mask);
> + struct cpumask *cpus = this_cpu_ptr(load_balance_mask);
>
>
> I think the conversion is wrong. it should be
> *this_cpu_ptr(&load_balance_mask);

Hmmm.... that is going to cause some pretty strange looking code. Would
the compiler/sparse not complain if the wrong type of pointer is assigned
to?


If we are retrieving a pointer then the right way to do things would be:

cpus = this_cpu_read(load_balance_mask);





\
 
 \ /
  Last update: 2014-08-01 16:41    [W:0.075 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site