Messages in this thread | | | Date | Fri, 1 Aug 2014 09:34:44 -0400 | From | Johannes Weiner <> | Subject | Re: [patch 2/3] mm, oom: remove unnecessary check for NULL zonelist |
| |
On Fri, Aug 01, 2014 at 02:10:37AM -0700, David Rientjes wrote: > On Thu, 31 Jul 2014, Johannes Weiner wrote: > > > out_of_memory() wants the zonelist that was used during allocation, > > not just the random first node's zonelist that's simply picked to > > serialize page fault OOM kills system-wide. > > > > This would even change how panic_on_oom behaves for page fault OOMs > > (in a completely unpredictable way) if we get CONSTRAINED_CPUSET. > > > > This change makes no sense to me. > > > > Allocations during fault will be constrained by the cpuset's mems, if we > are oom then why would we panic when panic_on_oom == 1?
Can you please address the concerns I raised?
And please describe user-visible changes in the changelog.
| |