Messages in this thread | | | From | Jingoo Han <> | Subject | Re: [PATCH 1/2] phy: Kconfig: Re-organize Exynos USB 2.0 PHY configs | Date | Wed, 09 Jul 2014 13:07:31 +0900 |
| |
On Wednesday, July 09, 2014 12:42 PM, Sachin Kamat wrote: > On Tue, Jul 8, 2014 at 9:15 PM, Tomasz Figa <t.figa@samsung.com> wrote: > > On 30.06.2014 10:56, Sachin Kamat wrote: > >> Since the USB 2.0 PHYs are required only with EHCI/OHCI USB drivers, > > > > That's not true. They are also required for USB gadget controller > > supported by the DWC2 gadget driver (formerly s3c-hsotg). Otherwise the > > change makes sense to me. > > Do you propose I amend just the patch description or also add a dependency on > USB_DWC2 along with EHCI and OHCI. I do not have anything to test this. Based > on your input I will re-spin the patch.
I agree with Tomasz Figa's statement. Personally, I think that it would be good to amend the commit message and add a dependency on USB_DWC2. :-) Thank you.
Best regards, Jingoo Han
> > -- > Regards, > Sachin.
| |