Messages in this thread | | | Subject | Re: [PATCH v1 1/5] seq_file: provide an analogue of print_hex_dump() | From | Joe Perches <> | Date | Wed, 09 Jul 2014 14:21:08 -0700 |
| |
On Wed, 2014-07-09 at 22:39 +0200, Marek Vasut wrote: > The above function looks like almost verbatim copy of print_hex_dump(). The only > difference I can spot is that it's calling seq_printf() instead of printk(). Can > you not instead generalize print_hex_dump() and based on it's invocation, make > it call either seq_printf() or printk() ?
How do you propose doing that given any seq_<foo> call requires a struct seq_file * and print_hex_dump needs a KERN_<LEVEL>.
Is there an actual value to it?
| |