lkml.org 
[lkml]   [2014]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] modules: Fix build error in moduleloader.h
On Tue, 08 Jul 2014 09:10:09 +0930
Rusty Russell <rusty@rustcorp.com.au> wrote:

> Subject: modules: Fix build error in moduleloader.h
>
> Fengguang Wu's build bot detected that if moduleloader.h is included in
> a C file (used by ftrace and kprobes to access module_alloc() when
> available), that it can fail to build if CONFIG_MODULES and
> CONFIG_MODULES_USE_ELF_REL is not defined.
>
> This is because there's a printk() that dereferences struct module to
> print the name of the module. But as struct module does not exist when
> CONFIG_MODULES is not defined we get this error:
>
> include/linux/moduleloader.h: In function 'apply_relocate':
> >> include/linux/moduleloader.h:48:63: error: dereferencing pointer to
> >> incomplete type
> printk(KERN_ERR "module %s: REL relocation unsupported\n", me->name);
> ^
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Based-on-the-true-story-by: Steven Rostedt <rostedt@goodmis.org>

Confirms-rustys-story-ends-the-same-by: Steven Rostedt <rostedt@goodmis.org>

-- Steve


> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
>


\
 
 \ /
  Last update: 2014-07-08 17:41    [W:0.145 / U:0.288 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site