Messages in this thread | | | Date | Tue, 8 Jul 2014 13:54:58 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCHv7 3/3] edac: altera: Add EDAC support for Altera SoC SDRAM Controller. |
| |
On Tue, Jul 08, 2014 at 01:52:05PM +0200, Pavel Machek wrote: > I'm not joking. Try to understand and verify the code above. You > can't. The "descriptive macro names" are useless; all the code does is > split register in pieces. With the numbers it would be very obvious.
No, you need to fix the names not switch to naked numbers.
-- Regards/Gruss, Boris.
Sent from a fat crate under my desk. Formatting is fine. --
| |