lkml.org 
[lkml]   [2014]   [Jul]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.14 59/94] net: allwinner: emac: Add missing free_irq
    Date
    3.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Maxime Ripard <maxime.ripard@free-electrons.com>

    commit b91113282bf44df46aba374a0b8f88a75bfd4b3f upstream.

    If the mdio probe function fails in emac_open, the interrupt we just requested
    isn't freed. If emac_open is called again, for example because we try to set up
    the interface again, the kernel will oops because the interrupt wasn't properly
    released.

    Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/net/ethernet/allwinner/sun4i-emac.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/drivers/net/ethernet/allwinner/sun4i-emac.c
    +++ b/drivers/net/ethernet/allwinner/sun4i-emac.c
    @@ -725,6 +725,7 @@ static int emac_open(struct net_device *

    ret = emac_mdio_probe(dev);
    if (ret < 0) {
    + free_irq(dev->irq, dev);
    netdev_err(dev, "cannot probe MDIO bus\n");
    return ret;
    }



    \
     
     \ /
      Last update: 2014-07-08 04:21    [W:4.246 / U:0.536 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site