Messages in this thread | | | Date | Mon, 7 Jul 2014 22:52:26 +0200 | Subject | Re: [PATCH] video: fbdev: core: fbmon.c: Cleaning up useless assignment of function parameter | From | Rickard Strandqvist <> |
| |
2014-07-07 22:43 GMT+02:00 Geert Uytterhoeven <geert@linux-m68k.org>: > On Sun, Jul 6, 2014 at 7:25 PM, Rickard Strandqvist > <rickard_strandqvist@spectrumdigital.se> wrote: >> Remove assignment of function parameter, that has no effect outside the function >> >> This was found using a static code analysis program called cppcheck >> >> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> >> --- >> drivers/video/fbdev/core/fbmon.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/drivers/video/fbdev/core/fbmon.c b/drivers/video/fbdev/core/fbmon.c >> index 5b0e313..71ec1ab 100644 >> --- a/drivers/video/fbdev/core/fbmon.c >> +++ b/drivers/video/fbdev/core/fbmon.c >> @@ -1481,7 +1481,6 @@ int fb_parse_edid(unsigned char *edid, struct fb_var_screeninfo *var) >> } >> void fb_edid_to_monspecs(unsigned char *edid, struct fb_monspecs *specs) >> { >> - specs = NULL; > > I guess the intention was: > > memset(specs, 0, sizeof(struct fb_monspecs));
Hi Geert!
Yeah, maybe. Just looks to be a little too elementary mistake..?
But do you want me to change it to that?
With a: if(specs) memset()
maybe..?
Kind regards Rickard Strandqvist
| |