lkml.org 
[lkml]   [2014]   [Jul]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] parisc: Remove sizeof(frame) from call to get_sigframe
On Mon, 7 Jul 2014, One Thousand Gnomes wrote:

> > This removes the sizeof(frame) from the call to get_sigframe on line
> > 243 in order to fix the call to this function as the sizeof in not
> > needed to call this function.
>
> If you are going to submit patches then
>
> - actually read what you are submitting
>
> - check it actually compiles
>
> - run it on the system in question and verify your changed code paths are
> used
>
> *then* consider submitting it, otherwise all you are doing is wasting
> people's time.

Seconded. Nicholas, this is a third time I've seen patch from you in my
mailbox that didn't make any sense whatsoever. Please be more careful,
once certain reputation is gained, it's very difficult to escape it.

--
Jiri Kosina
SUSE Labs


\
 
 \ /
  Last update: 2014-07-07 15:41    [W:0.041 / U:21.880 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site