lkml.org 
[lkml]   [2014]   [Jul]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.4 28/44] acpi/video_detect: blacklist samsung x360
    Date
    3.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Corentin Chary <corentin.chary@gmail.com>

    commit 084940d5b101e9ca91a689eb5048151b14076839 upstream.

    On Samsung X360, the BIOS will set a flag (VDRV) if the generic
    ACPI backlight device is used. This flag will definitively break
    the backlight interface (even the vendor interface) untill next
    reboot. It's why we should prevent video.ko from being used here
    and we can't rely on a later call to acpi_video_unregister().

    Signed-off-by: Corentin Chary <corentin.chary@gmail.com>
    Signed-off-by: Matthew Garrett <mjg@redhat.com>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    Cc: Yijing Wang <wangyijing@huawei.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/acpi/video_detect.c | 29 +++++++++++++++++++++++++++++
    1 file changed, 29 insertions(+)

    --- a/drivers/acpi/video_detect.c
    +++ b/drivers/acpi/video_detect.c
    @@ -132,6 +132,33 @@ find_video(acpi_handle handle, u32 lvl,
    return AE_OK;
    }

    +/* Force to use vendor driver when the ACPI device is known to be
    + * buggy */
    +static int video_detect_force_vendor(const struct dmi_system_id *d)
    +{
    + acpi_video_support |= ACPI_VIDEO_BACKLIGHT_DMI_VENDOR;
    + return 0;
    +}
    +
    +static struct dmi_system_id video_detect_dmi_table[] = {
    + /* On Samsung X360, the BIOS will set a flag (VDRV) if generic
    + * ACPI backlight device is used. This flag will definitively break
    + * the backlight interface (even the vendor interface) untill next
    + * reboot. It's why we should prevent video.ko from being used here
    + * and we can't rely on a later call to acpi_video_unregister().
    + */
    + {
    + .callback = video_detect_force_vendor,
    + .ident = "X360",
    + .matches = {
    + DMI_MATCH(DMI_SYS_VENDOR, "SAMSUNG ELECTRONICS CO., LTD."),
    + DMI_MATCH(DMI_PRODUCT_NAME, "X360"),
    + DMI_MATCH(DMI_BOARD_NAME, "X360"),
    + },
    + },
    + { },
    +};
    +
    /*
    * Returns the video capabilities of a specific ACPI graphics device
    *
    @@ -164,6 +191,8 @@ long acpi_video_get_capabilities(acpi_ha
    * ACPI_VIDEO_BACKLIGHT_DMI_VENDOR;
    *}
    */
    +
    + dmi_check_system(video_detect_dmi_table);
    } else {
    status = acpi_bus_get_device(graphics_handle, &tmp_dev);
    if (ACPI_FAILURE(status)) {



    \
     
     \ /
      Last update: 2014-07-11 17:41    [W:3.619 / U:3.484 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site