Messages in this thread | | | Date | Mon, 7 Jul 2014 11:03:41 +0300 | Subject | Re: [PATCH] appletalk: Set skb with destructor | From | Andrey Utkin <> |
| |
2014-07-07 0:42 GMT+03:00 Eric Dumazet <eric.dumazet@gmail.com>: >> /* Queue packet (standard) */ >> + sock_hold(sock); >> + skb->destructor = atalk_skb_destructor; >> skb->sk = sock; > > This part is not needed : sock_queue_rcv_skb() already does the right > thing : It calls skb_set_owner_r(skb, sk); > > You should therefore remove the "skb->sk = sock;" line
If it is so, i think this should be as another patch with its own reasoning.
-- Andrey Utkin
| |