lkml.org 
[lkml]   [2014]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/4] Staging: rts5208: Use standard print_hex_dump_debug
From
Date
On Sun, 2014-07-06 at 18:12 +0200, Fabio Falzoi wrote:
> Use print_hex_dump_debug to have memory properly dumped only when dynamic
> debug is enabled.

Not true.
Now it prints all the time when !CONFIG_DYNAMIC_DEBUG
and CONFIG_PRINTK.

> diff --git a/drivers/staging/rts5208/trace.h b/drivers/staging/rts5208/trace.h
[]
> -#ifdef CONFIG_RTS5208_DEBUG
> -#define RTSX_DUMP(buf, buf_len) \
> - print_hex_dump(KERN_DEBUG, KBUILD_MODNAME ": ", \
> - DUMP_PREFIX_NONE, 16, 1, (buf), (buf_len), false)
> -#else
> -#define RTSX_DUMP(buf, buf_len)
> -#endif
> -
> #endif /* __REALTEK_RTSX_TRACE_H */

Before it would not print at all if !CONFIG_RTS5208_DEBUG.



\
 
 \ /
  Last update: 2014-07-06 19:01    [W:1.189 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site