Messages in this thread | | | Date | Fri, 4 Jul 2014 21:38:31 +0200 | From | Oleg Nesterov <> | Subject | Re: __trace_remove_event_dirs() leaks file->filter ? (Was: probe_event_disable()->synchronize_sched()) |
| |
On 07/04, Masami Hiramatsu wrote: > > (2014/07/04 2:01), Oleg Nesterov wrote: > > On 07/03, Oleg Nesterov wrote: > >> > >> Hmm. Off-topic, but it seems that instance_rmdir() leaks the memory? Say, > >> file->filter? > > > > Perhaps I am totally confused, but don't we need something like the patch > > below? I'll try to recheck later... > > > > Better yet, we can probably move destroy_preds() from event_remove() to > > remove_event_file_dir()... not sure, need to recheck. > > Ah, yes, it seems event_remove releases preds, and remove_event_file_dir() > called from event_trace_del_tracer() doesn't release it. > > BTW, with following patch, we'd better remove destroy_preds() from > event_remove() and add destroy_call_preds() at the very last of the > function.
Yes, please see "Better yet" above. And probably we can simply remove destroy_preds() after that.
But I still need to reccheck, didn't have time today. And you know what? call->filter logic looks broken too ;)
Oleg.
| |