Messages in this thread Patch in this message | | | Date | Fri, 4 Jul 2014 23:57:56 +0530 | From | Himangi Saraogi <> | Subject | [PATCH] qla4xxx: Return -ENOMEM on memory allocation failure |
| |
In this code, 0 is returned on memory allocation failure, even though other failures return -ENOMEM or other similar values.
A simplified version of the Coccinelle semantic match that finds this problem is as follows:
// <smpl> @@ expression ret; expression x,e1,e2,e3; identifier alloc; @@
ret = 0 ... when != ret = e1 *x = alloc(...) ... when != ret = e2 if (x == NULL) { ... when != ret = e3 return ret; } // </smpl>
Signed-off-by: Himangi Saraogi <himangi774@gmail.com> Acked-by: Julia Lawall <julia.lawall@lip6.fr> --- drivers/scsi/qla4xxx/ql4_os.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c index c5d9564..72ba671 100644 --- a/drivers/scsi/qla4xxx/ql4_os.c +++ b/drivers/scsi/qla4xxx/ql4_os.c @@ -1050,6 +1050,7 @@ static int qla4xxx_get_host_stats(struct Scsi_Host *shost, char *buf, int len) if (!ql_iscsi_stats) { ql4_printk(KERN_ERR, ha, "Unable to allocate memory for iscsi stats\n"); + ret = -ENOMEM; goto exit_host_stats; } -- 1.9.1
| |